Reply pack

Developer PR Review

Reusable developer communication snippets for pull requests, review comments, standups, bugs, testing, releases, and incidents.

Download pack (30 replies) Open in Text Expander → Settings → Import Collection

PR Review

Review Start

Taking a pass now. I'll focus on correctness, test coverage, and any release-risky edge cases.
Need Context

Could you add a short note to the PR description covering the purpose, main changes, and how this was tested? That will make the review easier to follow.
Review Order

For review order, I suggest starting with %%CURSOR%%, then checking the tests and wiring changes after that.
LGTM

LGTM. I left only non-blocking comments, so this is good to merge once CI is green.
Request Changes

Thanks. I'm requesting changes for the blocking items I marked inline. The rest is optional polish.
Second Pass

I reviewed the latest push. The main concerns are resolved; I'm doing one final pass on tests and edge cases.

Question

question: Can you clarify the expected behavior here? I'm not sure whether this path should handle %%CLIPBOARD%% or fail earlier.
Blocking Issue

issue (blocking): This looks like it can break when %%CLIPBOARD%%. Can we guard that case or add a test that documents why it is impossible?
Suggestion

suggestion: Could we move this into %%CURSOR%%? It would keep the calling code smaller and make the behavior easier to test directly.
Nitpick

nitpick (non-blocking): Small naming suggestion: %%CLIPBOARD%% might be clearer here.
Praise Test

praise: This test is a good regression case. It captures the user-facing behavior without coupling too tightly to implementation details.
Security

issue (security, blocking): This path appears to trust %%CLIPBOARD%%. Can we validate or sanitize it before use?
Performance

question (performance): Do we expect this to run on large inputs? If so, we may want to avoid %%CURSOR%% in the hot path.
API Change

issue (blocking): This changes the public behavior of %%CLIPBOARD%%. Can we either preserve compatibility or call out the migration path in the PR?
Test Request

suggestion (test): Could you add coverage for %%CLIPBOARD%%? That seems like the edge case most likely to regress.

Ready Review

This is ready for review. Summary: %%CURSOR%%. Tested with: %%CLIPBOARD%%.
WIP Direction

Still in progress. I'm sharing early for direction on %%CURSOR%%; please hold detailed review until I mark it ready.
Updated

Updated based on feedback. Main changes: %%CURSOR%%. I also re-ran %%CLIPBOARD%%.
Tradeoff

I chose this approach because %%CURSOR%%. The tradeoff is %%CLIPBOARD%%; open to changing it if reviewers prefer the other direction.
Rereview

Ready for another look. I addressed the blocking comments and replied inline where I made a different call.

Standup Blocked

Yesterday: %%CLIPBOARD%%. Today: %%CURSOR%%. Blocked on: review/decision from @.
Standup Review

Today I'm focused on reviewing %%CLIPBOARD%%, then I'll pick up %%CURSOR%% if there's time.
Standup Risk

Small risk: %%CLIPBOARD%%. I'm checking that first so we know whether this needs scope adjustment.

Bug Repro

I can reproduce this with: %%CLIPBOARD%%. Expected: %%CURSOR%%. Actual:
Need Info

Could you share the exact steps, environment, and any relevant logs/screenshots? I'm missing enough context to reproduce this reliably.
Issue Triage

This looks valid. Proposed next step: confirm scope, add a failing test or repro, then decide whether it belongs in the current milestone.

Test Plan

Test plan: unit coverage for %%CLIPBOARD%%, integration coverage for %%CURSOR%%, and manual verification of the main user flow.

Release Ready

Release note draft: %%CURSOR%%. Risk level: low/medium/high. Rollback: revert %%CLIPBOARD%%.
Release Hold

I'd hold the release until we resolve %%CLIPBOARD%%. It affects %%CURSOR%% and does not look safe to ship as-is.

Incident Update

Incident update: impact is %%CLIPBOARD%%. Current status: %%CURSOR%%. Next update by: %%TIME +1h%%.